HBX-2936 Set up automated releases for Hibernate Tools #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
it is used in the release scripts hence would be best if Tools come with one already rather that rely on scripts to generate the wrapper.
so that we do not need to publish parent POMs
marko-bekhta
force-pushed
the
build/HBX-2936-Set-up-automated-releases-for-Hibernate-Tools
branch
from
f6733aa to
6e6ac3a
Compare
marko-bekhta
force-pushed
the
build/HBX-2936-Set-up-automated-releases-for-Hibernate-Tools
branch
5 times, most recently
from
2668857 to
c043280
Compare
…org.hibernate.tool.api.version.Version
as it is build by Gradle, and we need to add an extra jar to the artifacts we publish
marko-bekhta
force-pushed
the
build/HBX-2936-Set-up-automated-releases-for-Hibernate-Tools
branch
from
c043280 to
b993d3f
Compare
koentsje
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HBX-2936
Release scripts that we have are using the maven wrapper (
mwnv.) Hence this PR adds it. Tools inherit the JBoss parent and it has min maven version defined as 3.6.2 so that's the version for which the wrapper is generated. I'm not sure what version is actually used by the Tools if it's different from the one defined in that parent...Then the following commit:
maven-deploy-pluginDeployment is deferred till the "reports" module execution, which is the last one.
By default, gpg signing and staging of artifacts by nexus plugins are skipped (
deploy.skip=true) and it is enabled in each module that has to be published explicitly by settingdeploy.skip=false.Run this locally and got these artifacts staged:
Note that the list above is missing the
hibernate-tools-gradle. Looking at what it's publishing https://repo1.maven.org/maven2/org/hibernate/tool/hibernate-tools-gradle/7.0.0.Beta1/ it seems like an empty jar ... so I wasn't sure whether that should be included.And last but not least... Adding the maven flatten plugin is to make the POMs for the artifacts we publish not reference any parent POMs. This way, we wouldn't need to publish
hibernate-tools-parentOpening this a draft for now. Will need to check with @koentsje to see if nothing is missing and to better understand what should happen with that gradle module. (maybe ping me on Monday?)
Once everything is okay, we can create a job on CI. ( and probably backport this patch to other maintained branches ...)